Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make extension fire-and-forget #24

Closed
wants to merge 4 commits into from
Closed

Make extension fire-and-forget #24

wants to merge 4 commits into from

Conversation

JohnyP36
Copy link
Owner

@JohnyP36 JohnyP36 commented Nov 4, 2023

Any additions, changes or removals is at the Authors discretion.
You're free to counterargue (to a certain point) if you disagree with the decision.
To avoid being banned, don't constantly re-open or create new (related) issue reports or pull requests.

Prerequisites

  • I've read the Code of Conduct and the Contributing Guidelines
  • This is more than one or two issue(s)
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • Other webextensions related to Youtube are disabled
    • using a new, unmodified browser profile
  • I am running the latest version of the extension

Describe the issue

As it seems that most user install this extension and forget about it (e.g. fire-and-forget) I had to change the code for autoplay to the opposite, so it would turn off YT autoplay on installation.
Partly in fulfillment of #21

Browser & Extension version

Browser name & version Extension Version Operating System
`MS Edge 119` `2.0.9` `Windows 10, 22H2`

Notes

Reversing the code is possible but not for the position of the slider in the popup: First to the left meant "stopping YT autoplay", now it means "NOT stopping / do nothing".

@JohnyP36 JohnyP36 force-pushed the JohnyP36-fireandforget branch from d1e8aec to 02eba3a Compare November 4, 2023 21:26
@JohnyP36
Copy link
Owner Author

JohnyP36 commented Nov 5, 2023

@amaurea Given your request at issue #21 I drafted this PR.
But I need some feedback from you before I can merge it.

Would you like to answer the following questions?

  1. After you installed the extension/add-on did you open the popup menu to check the settings?
  2. Did you understand what each switch is doing when it's green outlined/filled (in other words: turned on)?
  3. Can you explain to my what you thing the extension is doing when the top switch (stopping YouTube autoplay) is turned off (thus has a red color)?

Thank you in advance.

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the stale This issue or pull request is stale label Dec 18, 2023
@JohnyP36
Copy link
Owner Author

JohnyP36 commented Jan 4, 2024 •
edited
Loading

@amaurea It has been a while since you opened issue #21 .
It would be easier if Firefox supported MV3 the same way as Chromium-based browser, but for now I created this PR which is still waiting for your feedback.

Can you please react to my previous comment? Otherwise this PR will be closed.

@JohnyP36
C: make ext. fire-and-forget
4690a22 
Reverse code to make autoplay turn off on installation
@JohnyP36
Make autoplay function in reverse
0832e17
@JohnyP36
Make autoplay function in reverse
3c3f735
@JohnyP36
C: make ext. fire-and-forget
bc92606 
Reverse code to make autoplay turn off on installation
@JohnyP36 JohnyP36 force-pushed the JohnyP36-fireandforget branch from 02eba3a to bc92606 Compare January 4, 2024 13:40
@github-actions github-actions bot removed the stale This issue or pull request is stale label Jan 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024 •
edited by JohnyP36
Loading

Sorry @amaurea, you didn't give feedback in time. That's why this PR already got the "stale" label and now get closed.

@github-actions github-actions bot closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
No Feedback => Closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JohnyP36